-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add optional chaining in the event CSS
is null
#472
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey, thank you so much for working on this! |
I wonder if a better solution might be to do |
Hey @LeaVerou I'm unsure on the exact reason why but we are getting a |
Hey @LeaVerou is there any changes that you would like for me to do to this PR to solve the issue? |
Hey @LeaVerou any update on this issue? |
Hi there! Sorry for the delay. I’m just not sure in what case If it's something that happens naturally in some case or in some environment, sure, I'd be happy to merge this, but when I asked the response was that you didn’t know why |
@LeaVerou We did some digging and found that users are following this guide for jest-preset-angular in which they are being told to override |
That very much sounds like it should be fixed at the point which is causing this problem, which I see has been raised as an issue. |
I think I'm tending to agree. @straker as a workaround you can check if it's null and set it to undefined if so. |
Adding this in the event that
CSS
global is null this doesn't throw an error. There was a user that went thru this code path andCSS
was null and threw an error.